Skip to content

Fix JSON tag for ServiceProviderConfig type field #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2025
Merged

Fix JSON tag for ServiceProviderConfig type field #831

merged 1 commit into from
Oct 29, 2025

Conversation

@mathieu-benoit
Copy link
Contributor

@mathieu-benoit mathieu-benoit commented Oct 29, 2025 •
edited
Loading

Fix JSON tag for ServiceProviderConfig type field.

I think this is a typo, since it was created there: #758.

Just for context, with this snippet of my Compose file:

...
services:
    my-model:
        provider:
            type: model
            options:
                model:
                    - ai/smollm2

When doing this https://github.com/score-spec/score-compose/blob/main/internal/patching/patching.go#L131, getting this error when doing a JSON decode/validation:

json: unknown field "type"

While not getting any error when running docker compose up on this file (which is successfully doing the YAML decode/validation way).

glours
glours approved these changes Oct 29, 2025
View reviewed changes
Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@glours glours merged commit df0892c into compose-spec:main Oct 29, 2025
8 checks passed
@mathieu-benoit mathieu-benoit deleted the patch-1 branch October 29, 2025 20:35
@mathieu-benoit mathieu-benoit mentioned this pull request Oct 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glours glours glours approved these changes

@ndeloof ndeloof Awaiting requested review from ndeloof ndeloof is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mathieu-benoit @glours